How to fix broken imports from Cursor

1// Cursor Chat prompt (Cmd+L, Ask mode):
2// @codebase Analyze the import statements across all
3// .ts and .js files in src/. Identify any circular
4// import chains where module A imports from B and B
5// imports from A (directly or through intermediaries).
6// List each circular chain with the full import path.
7
8// You can also use a CLI tool for verification:
9// npx madge --circular --extensions ts src/

1---
2description: Import hierarchy rules to prevent circular dependencies
3globs: "src/**/*.ts"
4alwaysApply: true
5---
6
7## Import Hierarchy (top imports from bottom, NEVER reverse)
81. src/routes/ — imports from services, middleware
92. src/services/ — imports from repositories, utils
103. src/repositories/ — imports from models, utils
114. src/models/ — imports from types only
125. src/middleware/ — imports from services, utils
136. src/utils/ — imports from types only, NO other internal imports
147. src/types/ — ZERO internal imports (leaf module)
15
16## Rules
17- NEVER import from a higher layer (services must NOT import from routes)
18- NEVER create mutual imports between files in the same directory
19- Shared types go in src/types/, not in service or route files
20- If two modules need each other, extract the shared dependency into src/types/ or src/utils/
21- Use dependency injection instead of direct imports for cross-cutting concerns

1// Composer prompt (Cmd+I):
2// @src/services/userService.ts @src/services/orderService.ts
3// These two files have circular imports because they both
4// define and use shared types. Extract all shared interfaces
5// and types into src/types/shared.ts. Update both files to
6// import from the new types file. Remove the circular import.
7
8// Before (circular):
9// userService.ts: import { Order } from './orderService'
10// orderService.ts: import { User } from './userService'
11
12// After (fixed):
13// types/shared.ts: export interface User {...} export interface Order {...}
14// userService.ts: import { User, Order } from '@/types/shared'
15// orderService.ts: import { User, Order } from '@/types/shared'

1// Cursor Chat prompt (Cmd+L):
2// @src/services/userService.ts @src/services/notificationService.ts
3// These services call each other: userService sends notifications,
4// notificationService looks up user preferences. Refactor to use
5// dependency injection. Pass the dependency through the constructor
6// instead of importing directly.
7
8// Expected pattern:
9class UserService {
10  constructor(private notificationService: INotificationService) {}
11  
12  async deleteUser(id: string) {
13    await this.notificationService.send(id, 'Account deleted');
14  }
15}
16
17class NotificationService {
18  constructor(private userService: IUserService) {}
19  
20  async send(userId: string, message: string) {
21    const prefs = await this.userService.getPreferences(userId);
22    // send based on prefs
23  }
24}

1// Terminal:
2npx madge --circular --extensions ts src/
3
4// Or Cursor Chat (Cmd+L):
5// @codebase Re-check for circular imports in src/.
6// Verify that the import hierarchy is respected:
7// routes -> services -> repositories -> models -> types.
8// Report any remaining violations.